Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize remote fixtures #2255

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

volodymyrss
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Dec 23, 2021

Hello @volodymyrss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 140:9: E265 block comment should start with '# '

Comment last updated at 2022-03-26 08:59:26 UTC

volodymyrss added a commit to oda-hub/astroquery that referenced this pull request Dec 23, 2021
@bsipocz bsipocz added this to the v0.4.7 milestone Mar 19, 2022
bsipocz pushed a commit to bsipocz/astroquery that referenced this pull request Mar 25, 2022
@bsipocz
Copy link
Member

bsipocz commented Mar 25, 2022

@volodymyrss - Is this still relevant? If yes, could you remove the commits that are already in main from #2250, and if not then close it? Thanks!

@volodymyrss volodymyrss force-pushed the parametrize-remote-fixtures branch from 80b2ec1 to e127104 Compare March 26, 2022 08:59
@volodymyrss
Copy link
Contributor Author

@volodymyrss - Is this still relevant? If yes, could you remove the commits that are already in main from #2250, and if not then close it? Thanks!

It's still relevant, it's meant to relocate the fixtures for this test parametrization (creating remote data automatically) to common location, not specific to heasarc.
I had no time to finish it yet, sorry. It might take some month before I get to it again. Is it ok to keep it as draft for a while? I could also close and recreate it later.
I made it all in one commit for now.

@bsipocz bsipocz removed this from the v0.4.7 milestone Mar 26, 2022
@bsipocz
Copy link
Member

bsipocz commented Mar 26, 2022

Is it ok to keep it as draft for a while?

That sounds all good, as you may have seen we don't put a time limit on PRs in this repo. However, I removed the milestone so it won't pop up at release time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants